The Xbox Scorpio is basically a new console that is backwards compatible with the Xbox one so it's coded as an Xbox one. It's like buying TGC on pc and later upgrading your PC (in laymans terms)
The way I understand it from reading the Digital Foundry article on "Five Ways Scorpio XBox One Games", the biggest advantage Scorpio would offer to the XBox One version of TGC 2 is since The Golf Club, and I suspect The Golf Club 2 have an option to turn the vsync off, the Scorpio will theoretically bump the performance up to 60 FPS. The Scorpio can help an XBox One game run more consistently at its target frame rate, from what I read, but if the XB1 game doesn't have a locked vsync, shouldn't that free the Scorpio to take it considerably higher?
The Scorpio will also help the texture filtering of XBox One games, taking it from the norm of 4X AF, to 16X AF. That makes a considerable difference in my PC gaming experience. It will also offer faster loading of XBox One games, but that hasn't been a real problem with TGC, IMO.
I guess in terms of graphics, the best the Scorpio can do is upscale the 1080p (hopefully) graphics of TGC 2 to 4K, for what that's worth, but I think we all know that upscaled 4K can't hold a candle to native 4K. Having educated myself a little more on the Scorpio, I'd say your right about HBS having to have an update, or possibly even a new stand alone version of TGC 2 that does support native 4K for the Scorpio. If that happens, I would hope games with the Scorpio version could hook up with and play in the XBox One Societies.